Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3655 closed defect (fixed)

Adblock Browser 1.3.0 shows empty blocking list on iOS 8.4.x

Reported by: pavelz Assignee:
Priority: P1 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description

Environment

iOS 8.4.x
Adblock Browser 1.3.0 814

How to reproduce

  1. Load the browser
  2. Open Settings > Adblock Plus > Ad Blocking

Observed behaviour

The list of language subscriptions is empty. The browser is not blocking any ads.

Expected behaviour

The list shows language subscriptions with English selected. The browser blocks ads as expected

Change History (6)

comment:1 Changed 4 years ago by pavelz

The new ABB API integration
https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/src/5385640706f189b9a0d1c036f2df10d9912538e3/api.js?fileviewer=file-view-default#api.js-29

expects Element.prototype.children to be implemented. WebKit on iOS 8.4.x implements only HTMLElement.prototype.children but not the generic Element (which is a result of XMLParser). As a result the above line returns null and no language subscriptions are ever loaded -> not displayed, not usable for blocking

comment:2 Changed 4 years ago by pavelz

Proposed fix
https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/pull-requests/1/replaced-children-with/diff

use getElementsByTagName instead - which is what what background.js uses in addSubscription

Last edited 4 years ago by pavelz (previous) (diff)

comment:3 Changed 4 years ago by mario

  • Ready set

comment:4 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in build 835 and later

comment:5 Changed 3 years ago by pavelz

  • Milestone set to Adblock-Browser-for-iOS-next

comment:6 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • All available Easylist languages are available in Settings>Adblock Plus>Ad Blocking and the first subscription shown is English and is active.
  • The browser blocks ads as expected.

ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1

Note: See TracTickets for help on using tickets.