Changes between Initial Version and Version 1 of Ticket #3659


Ignore:
Timestamp:
02/16/2016 11:48:57 AM (4 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3659

    • Property Status changed from new to reviewing
  • Ticket #3659 – Description

    initial v1  
    44=== What to change === 
    55Make `InvalidFilter` store an error ID, not the actual error text, similarly to how synchronizer does it. Converting the error ID into a localized string should be done by the UI. 
     6 
     7=== Integration notes === 
     8With this change `InvalidFilter.reason` will be an error (string) ID, not localized text any more. Two new translatable strings have to be added, we didn't localize these reasons before: filter_unknown_option ("Unknown filter option") and filter_invalid_regexp ("Invalid regular expression"). 
  • Ticket #3659 – Review URL(s)

    initial v1  
     1https://codereview.adblockplus.org/29336430/