Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3660 closed change (fixed)

Remove locale dependency from subscription classes

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Core Keywords:
Cc: sebastian, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29336491/

Description (last modified by trev)

Background

Subscription classes will currently use localized strings for default subscription titles, this makes for ugly dependencies.

What to change

Make subscription classes leave title empty if none is set. Showing default title instead of the empty one should be left to the UI code.

Integration notes

UI will have to deal with empty subscription titles now. Also, this change removes DownloadableSubscription.upgradeRequired field, version comparison between DownloadableSubscription.requiredVersion and current version has to be done in the UI now.

Change History (5)

comment:1 Changed 4 years ago by trev

  • Cc sebastian fhd added

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by trev

  • Description modified (diff)

comment:4 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This change looks to be working as expected. I couldn't see/trigger any obvious problems with subscription titles,

ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.