Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3669 closed change (fixed)

Refactor Puppet class adblockplus::log::uplink

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: #3576 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

... which has been introduced before #3638, but can undergo some major improvements as soon as class adblockplus::host has been merged:

  • Use a fully qualified rsa_public_key instead of the legacy $ssh_public_key fragment
  • Use the official $fqdn
  • Remove unused parameters not examined, like $role and $groups
  • Fetch default values from the Adblockplus::Host instance of the same $name

In addition, future use may focus on ensure_resource() calls on-demand, instead of relying on parameter $adblockplus::hosts and function create_resources().

Change History (2)

comment:1 Changed 4 years ago by matze

  • Blocked By 3638 removed
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed

In the context of #3825 class adblockplus::log::uplink is removed, hence this ticket here is considered obsolete.

comment:2 Changed 4 years ago by matze

  • Owner set to matze
Note: See TracTickets for help on using tickets.