Opened 21 months ago

Closed 8 months ago

Last modified 8 months ago

#3672 closed change (fixed)

Move antiadblockInit.js from adblockpluscore to adblockplusui

Reported by: trev Assignee: wspee
Priority: P2 Milestone:
Module: Core Keywords: goodfirstbug
Cc: kzar, sebastian Blocked By:
Blocking: #4715, #4716 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29366969/
https://codereview.adblockplus.org/29366966/
https://codereview.adblockplus.org/29369232/
https://codereview.adblockplus.org/29370594/

Description

Background

We agreed that antiadblockInit.js is actually UI code and doesn't belong into core.

What to change

Move antiadblockInit.js and the corresponding strings from adblockpluscore repository to adblockplusui.

Change History (12)

comment:1 Changed 21 months ago by sebastian

  • Cc kzar sebastian added
  • Keywords goodfirstbug added

comment:2 Changed 12 months ago by wspee

  • Owner set to wspee

comment:3 Changed 12 months ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 12 months ago by wspee

  • Blocking 4715 added

comment:5 Changed 12 months ago by wspee

  • Blocking 4716 added

comment:6 Changed 12 months ago by wspee

Please note #4715, #4716 which need to be fixed in conjunction.

comment:7 Changed 11 months ago by wspee

  • Review URL(s) modified (diff)

comment:10 Changed 11 months ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 9 months ago by wspee

  • Resolution fixed deleted
  • Review URL(s) modified (diff)
  • Status changed from closed to reopened

During the review of https://codereview.adblockplus.org/29366966/ it was also
suggested to replace the usage of Utils.getString with ext.i18n.getMessage.

Unfortunately I screwed that one up by not testing the changes in Firefox, I
assumed ext.i18n was universally available.

Firefox doesn't have ext.i18n and there is no way (afaict) to provide ext.i18n
for antiadblockInit in a sane fashion.

Therefore I propose to revert the switch to ext.i18n.getMessage in
antiadblockInit, see https://codereview.adblockplus.org/29370594/.

comment:12 Changed 8 months ago by sebastian

  • Resolution set to fixed
  • Status changed from reopened to closed

The review for the fix referred above is closed. Moreover, is this issue, while open, preventing dependent issues, i.e. #4715 which landed as well, from being closed. So I'm closing this issue now.

Last edited 8 months ago by sebastian (previous) (diff)
Note: See TracTickets for help on using tickets.