Opened 4 years ago

Last modified 2 months ago

#3674 closed change

Write a hg hook that adds a comment on the relevant issue for each commit — at Version 2

Reported by: fhd Assignee: fhd
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29336790

Description (last modified by fhd)

Background

Whenever we currently commit something linked to a specific issue, we manually add a comment pointing to that commit. That's fairly easy to automate, since commits always have the same format: Issue [number] - [message].

What to change

Write a hook (probably used for either incoming or changegroup that inspects the commit message and adds a comment to the issue mentioned.

As an added bonus, the hook could reject commits that don't use the right format or that refer to an issue that doesn't exist (note that Noissue - [message] is also valid). But that may be something better handled in a follow-up issue.

Change History (2)

comment:1 Changed 4 years ago by fhd

  • Component changed from Sitescripts to Infrastructure

Will probably end up in infrastructure rather than sitescripts because an internal hook makes more sense. But the jury is still out I suppose.

comment:2 Changed 4 years ago by fhd

  • Description modified (diff)
Note: See TracTickets for help on using tickets.