Opened 4 years ago

Closed 4 years ago

#3676 closed change (fixed)

Set up the hg hook that references commits in issues

Reported by: fhd Assignee: fhd
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: matze, trev Blocked By: #3674
Blocking: #3678 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29337751/
https://codereview.adblockplus.org/29337790/

Description (last modified by fhd)

Background

#3674 adds a hook that references commits in the respective issues. Once that has landed, we need to set it up.

What to change

Since Trac doesn't have an API out of the box, we first need to set that up:

  1. Install XmlRpcPlugin.
  2. Because we're using AccountManagerPlugin, we also need to install HttpAuthPlugin and configure it for the `/login/xmlrpc` path.
  3. Set up a new abpbot Trac user and give it the XML_RPC permission.

Once that is done, we need to set up the new hook as a pretxnchangegroup hook (see #3679) in the hgrc of all repositories on hg1.

Change History (14)

comment:1 Changed 4 years ago by fhd

  • Blocked By 3674 added

comment:2 Changed 4 years ago by fhd

  • Description modified (diff)

comment:3 Changed 4 years ago by fhd

  • Blocking 3678 added

comment:4 Changed 4 years ago by fhd

  • Description modified (diff)

comment:5 Changed 4 years ago by fhd

  • Cc matze trev added
  • Owner set to fhd

I'll have a go at this. Largely manual work, unfortunately... (Edit: No actually, I mixed something up: The Trac changes, except for creating the API user, will go through Puppet how it looks. Just the hgrc changes not, but those aren't the tricky part.)

Last edited 4 years ago by fhd (previous) (diff)

comment:6 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

The reviewable part is under review now. I'll do the manual work once that has landed.

comment:7 Changed 4 years ago by fhd

Code change landed: https://hg.adblockplus.org/infrastructure/rev/887722028fd2

(If everything goes well, this was the last time I had to do that :D)

comment:8 Changed 4 years ago by fhd

Created the user abpbot and granted it the XML_RPC permission.

comment:9 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)

Well there's one more infrastructure change required for this, the new hook needs to be configured on hg1. Added a review for that.

comment:10 Changed 4 years ago by fhd

Second change landed: https://hg.adblockplus.org/infrastructure/rev/4938cecd1473

(Yup, had to do it again...)

Also deployed. Now all that remains is to update the hgrcs...

comment:11 Changed 4 years ago by fhd

Tested it successfully with the adblockplussafariios repository and #3712. Chaning all the hgrcs now...

comment:12 Changed 4 years ago by fhd

Enabled the hook for the following repositories:

  • abp2blocklist
  • abpbot
  • abpcrawler
  • abpcustomization
  • abpwatcher
  • adblockbrowser-build
  • adblockbrowser
  • adblockplusandroid
  • adblockpluschrome
  • adblockpluscore
  • adblockplus
  • adblockplusie
  • adblockplussafariios
  • adblockplussbrowser
  • adblockplustests
  • adblockplusui
  • buildtools
  • cms
  • codingtools
  • contentblockerlists
  • downloads
  • elemhidehelper
  • facebook.adblockplus.me
  • infrastructure
  • libadblockplus-binaries
  • libadblockplus
  • notifications
  • screenshotter
  • share.adblockplus.org
  • sitescripts
  • subscribe.adblockplus.org
  • testpages.adblockplus.org
  • urlfixer
  • web.acceptableads.org
  • web.adblockbrowser.org
  • web.adblockplus.org
  • web.eyeo.com
  • youtube.adblockplus.me

Still wondering what exactly to do with some of the others.

comment:13 Changed 4 years ago by fhd

Forgot two, both are not just dependencies but forks:

  • jshydra
  • mozharness

I'll leave the rest alone.

Last edited 4 years ago by fhd (previous) (diff)

comment:14 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.