Opened 5 years ago

Last modified 12 months ago

#3680 new defect

[codereview] "Invalid IPv6 URL [ValueError]" when publishing comments

Reported by: trev Assignee:
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: matze Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


How to reproduce

  1. Add a comment on this line.
  2. Attempt to publish comments.

Observed behaviour

Error "Invalid IPv6 URL [ValueError]" shows up on

Expected behaviour

No error, usual list of comments.


This is a bug in django.utils.html.urlize, it attempts to highlight hgbook)}}]( as a URL and fails (urlparse.unsplit() throws the exception above). I hotfixed this on the server for now by adjusting the regular expression, Django's official patch however simply catches the exception. Unfortunately, Django's patch won't apply cleanly to Django 1.4 used by Rietveld.

Change History (2)

comment:2 Changed 18 months ago by Addu12


Last edited 12 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.