Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3685 closed change (fixed)

Remove dead migration code from subscription initilization

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29337566

Description

Background

We still run some migration code, removing the outdated https://easylist-downloads.adblockplus.org/chrome_supplement.txt subscription, and adding the Anti-Adblock list when migrating from before Adblock Plus 1.8.

That migration code not only has been in there for long enough, but also it's essentially dead code now as with #3446 no data are migrated at all when updating from a version older than Adblock Plus 1.9.

What to change

Remove the migration code, that removes the https://easylist-downloads.adblockplus.org/chrome_supplement.txt subscription and adds the Anti-Adblock list.

Change History (3)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-1.11-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Subscriptions still work / are added on install.

ABP 1.10.2.1559
Chrome 30 / Windows 7 x86
Chrome 47 / Windows 7 x86
Chrome 48 / Ubuntu 14.04 x64
Opera 19 / Windows 7 x86
Opera 35 / Windows 7 x86
Opera 35 / Ubuntu 14.04 x64
Safari 6 (OS X 10.8) / Safari 8 (OS X 10.10) / Safari 9 (OS X 10.11)

Note: See TracTickets for help on using tickets.