Opened on 02/23/2016 at 08:17:14 PM

Closed on 03/08/2016 at 12:18:17 AM

Last modified on 04/26/2016 at 03:23:58 PM

#3686 closed change (fixed)

Replace Exec['fetch_sitescripts'] with Class['sitescripts']

Reported by: matze Assignee: matze
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: fred Blocked By:
Blocking: #2314, #3576 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


Referencing Puppet resources declared within another scope is considered bad practice if the target entities are not explicitly documented to be included in the list of publicly accessible properties. Hence the multiple occurrences of require relationships referring directly to Exec['fetch_sitescripts'] are considered deprecated:

$ grep -R fetch_sitescripts *
modules/downloadserver/manifests/init.pp:      Exec['fetch_sitescripts'],
modules/notificationserver/manifests/init.pp:      Exec['fetch_sitescripts'],
modules/sitescripts/manifests/init.pp:  exec { "fetch_sitescripts":
modules/statsmaster/manifests/downloads.pp:                 Exec["fetch_sitescripts"]
modules/updateserver/manifests/init.pp:    require => [Exec['fetch_sitescripts'],
modules/updateserver/manifests/init.pp:      Exec["fetch_sitescripts"],
modules/web/manifests/server.pp:        Exec["fetch_sitescripts"],
modules/web/manifests/server.pp:      Exec['fetch_sitescripts', 'install_jsdoc'],

Those are to be replaced by references to Class['sitescripts'].

Attachments (0)

Change History (6)

comment:2 Changed on 03/06/2016 at 11:22:48 PM by matze

  • Owner set to matze

comment:3 Changed on 03/06/2016 at 11:23:03 PM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 03/08/2016 at 12:18:17 AM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
$ grep -R fetch_sitescripts *
modules/sitescripts/manifests/init.pp:  exec { "fetch_sitescripts":
modules/sitescripts/manifests/init.pp:    require => Exec["fetch_sitescripts"],

comment:6 Changed on 04/26/2016 at 03:23:58 PM by matze

  • Blocking 2314 added

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Note: See TracTickets for help on using tickets.