Opened 21 months ago

Closed 21 months ago

Last modified 2 months ago

#3695 closed change (fixed)

Edge exposes it's API with the "browser" namespace instead "chrome"

Reported by: sebastian Assignee: oleksandr
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: scottlow Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338058

Description

Background

Microsoft Edge is going to support a subset of the Chrome extension API. However, same as for Mozilla's Web Extensions, the namespace will be browser instead chrome.

As browser seems to become a standard, we might want to consider using it directly in the future, but as we have to develop compatibility changes for Edge in a fork for now, let's keep the change as small as possible.

What to change

Alias window.browser to window.chrome if it doesn't exist.

Change History (7)

comment:1 Changed 21 months ago by sebastian

  • Owner set to oleksandr
  • Review URL(s) modified (diff)

comment:3 Changed 19 months ago by sebastian

  • Cc scottlow added

comment:4 Changed 18 months ago by sebastian

  • Keywords edge removed
  • Platform changed from Unknown / Cross platform to Edge

comment:5 Changed 18 months ago by sebastian

  • Sensitive unset

comment:6 Changed 13 months ago by abpbot

A commit referencing this issue has landed:
Issue 3695 - Edge exposes it's API with the "browser" namespace

comment:7 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Tested through general use and checking that window.chrome exists in console in Edge/FF.

ABP 0.9.11.1849
Edge 40 / Windows 10

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10

ABP 2.99.0.1838beta
Firefox 53 / 55 / Windows 10

Note: See TracTickets for help on using tickets.