Opened 21 months ago

Closed 21 months ago

Last modified 13 months ago

#3696 closed change (fixed)

Fall back to tabs.create if windows.create isn't available

Reported by: sebastian Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: kzar, scottlow Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29338187/

Description

Background

With #2426 we started to show the "Block element" dialog as a popup using chrome.windows.create. Edge, however, won't support browser.windows.create from the beginning. So we need a fallback there.

What to change

Don't call chrome.windows.create if not available, fall back to opening a new tab (as we do on Safari).

Change History (6)

comment:1 Changed 21 months ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 21 months ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 19 months ago by sebastian

  • Cc scottlow added

comment:4 Changed 18 months ago by sebastian

  • Keywords edge removed
  • Platform changed from Unknown / Cross platform to Edge

comment:5 Changed 18 months ago by sebastian

  • Sensitive unset

comment:6 Changed 13 months ago by abpbot

Note: See TracTickets for help on using tickets.