Changes between Version 9 and Version 10 of Ticket #3697


Ignore:
Timestamp:
08/30/2017 11:42:23 AM (3 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3697 – Description

    v9 v10  
    11=== Background === 
    2 `chrome.i18n.getMessage("@ui_locale")` returns the language of the browser's user interface. 
    3 `chrome.i18n.getMessage("@bidi_dir")` returns the respective reading direction of that language. 
     2Much of the user interface in Adblock Plus relies on knowing which language the user is using, and the reading direction for it. Currently we use the getMessage API in combination with some special message IDs: 
    43 
    5 Adblock Plus relies on these, to show parts of the user interface dependent on the language, as well to account for right-to-left languages, such as Arabic. Microsoft Edge, however, doesn't support these special message IDs (yet). 
     4 - `chrome.i18n.getMessage("@ui_locale")` returns the language of the browser's user interface. 
     5 - `chrome.i18n.getMessage("@bidi_dir")` returns the respective reading direction of that language. 
     6 
     7The problem is that Microsoft Edge does not yet support those message IDs yet. 
    68 
    79=== What to change === 
     10 - Use `i18n.getUILanguage` instead of `i18n.getMessage("@ui_locale")`. 
     11 - If `i18n.getMessage("@bidi_dir")` returns `""` (empty string) fall back to the same logic we had on Safari to determine the reading direction of the UI locale, matching the locale against a list of known right-to-left languages. 
     12 - Update the adblockplusui dependency to revision [https://hg.adblockplus.org/adblockplusui/rev/104a61b1949d 104a61b1949d]. 
    813 
    9 * Use `i18n.getUILanguage` instead of `i18n.getMessage("@ui_locale")`. 
    10 * If `i18n.getMessage("@bidi_dir")` returns `""` (empty string) fall back to the same logic we had on Safari to determine the reading direction of the UI locale, matching the locale against a list of known right-to-left languages. 
    11  
    12 === Note === 
    13 This also requires an update to adblockplusui. Here is a full list of imported issues: 
    14 [[TicketQuery(id=5255|5326|5538|5540|5482|5384|5586,rows=title,table)]] 
    15 Note that there were also many other Noissue commits, which are imported here. They are mostly related to the new options page. That 
    16 said there has been a small change to how the links on the first run 
    17 page are setup: 
    18  
    19  - https://hg.adblockplus.org/adblockplusui/rev/461ee88245c7 
     14''Note: The adblockplusui dependency update includes many other changes. They mostly relate to the new options page and the copyright headers, but there is [https://hg.adblockplus.org/adblockplusui/rev/461ee88245c7 one small change to how the links on the first run page are setup].'' 
    2015 
    2116=== Hints for testers === 
    22  - Please make sure the correct filter list is selected by default 
    23  - Please make sure the correct UI language is selected by default 
    24  - Please check that right-to-left detection works correctly for languages that require that (for example Arabic). 
    25  - Please ensure that the links on the first run page still all work. 
     17 - Ensure that the correct filter list is selected by default. 
     18 - Ensure that the correct UI language is selected by default. 
     19 - Check that right-to-left detection works correctly for languages that require that (for example Arabic). 
     20 - Ensure that the links on the first run page still all work.