Changes between Version 2 and Version 7 of Ticket #3697


Ignore:
Timestamp:
08/29/2017 02:23:04 PM (2 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3697

    • Property Sensitive unset
    • Property Cc scottlow added
    • Property Blocked By changed from to 4084
    • Property Platform changed from Unknown / Cross platform to Edge
    • Property Keywords edge removed
  • Ticket #3697 – Description

    v2 v7  
    33`chrome.i18n.getMessage("@bidi_dir")` returns the respective reading direction of that language. 
    44 
    5 Adblock Plus relies on these, to show parts of the user interface dependent on the language, as well to account for right-to-left languages, such as Arabic. 
    6  
    7 Edge, however, won't support these special message IDs from the beginning. But it will support `browser.i18n.getUILanguage`, which we can fall back to. But note that since this API is new in Chrome 35, we still have to keep using `chrome.i18n.getMessage("@ui_locale")` on older Chrome versions. 
     5Adblock Plus relies on these, to show parts of the user interface dependent on the language, as well to account for right-to-left languages, such as Arabic. Microsoft Edge, however, doesn't support these special message IDs (yet). 
    86 
    97=== What to change === 
    108 
    11 * If `i18n.getMessage("@ui_locale")` returns `""` (empty string) fall back to `i18n.getUILanguage`. 
    12 * If `i18n.getMessage("@bidi_dir")` returns `""` (empty string) fall back to the same logic we use on Safari to determine the reading direction of the UI locale. 
     9* Use `i18n.getUILanguage` instead of `i18n.getMessage("@ui_locale")`. 
     10* If `i18n.getMessage("@bidi_dir")` returns `""` (empty string) fall back to the same logic we had on Safari to determine the reading direction of the UI locale, matching the locale against a list of known right-to-left languages.