Opened 6 years ago
Closed 5 years ago
#370 closed defect (fixed)
element blocking is previewed even if filter URL is removed completely
Reported by: | philll | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
Module: | Platform | Keywords: | |
Cc: | smultron45@… | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sebastian)
Environment
Chrome, Opera, Safari
How to reproduce
- Click on the ABP icon
- Select "Block element"
- Click on any element
- Edit or remove the filter
- Click "Save"
Observed behaviour
The element that was clicked on is instantly removed from the page.
Expected behaviour
The element(s) that match the the saved filters (if any) should be removed instead.
Change History (9)
comment:1 Changed 6 years ago by philll
- Description modified (diff)
comment:2 Changed 6 years ago by mapx
- Cc smultron45@… added
comment:3 Changed 6 years ago by mapx
comment:4 Changed 6 years ago by philll
- Owner set to greiner
- Status changed from new to assigned
comment:5 Changed 6 years ago by philll
- Review URL(s) modified (diff)
- Status changed from assigned to reviewing
comment:6 Changed 5 years ago by sebastian
- Description modified (diff)
I replaced the description in order to cover not only images and the case when the filter was edited.
comment:7 Changed 5 years ago by philll
- Component changed from Unknown to Platform
- Platform set to Unknown
comment:8 Changed 5 years ago by sebastian
- Owner changed from greiner to sebastian
- Review URL(s) modified (diff)
I'm taking this over now. I've uploaded a new patch, that injects CSS rules for the added element hiding filters and reuses "check collapse" functionality to determine whether the selected element should be blocked, as discussed in the other review.
comment:9 Changed 5 years ago by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
there is already a patch in review:
http://codereview.adblockplus.org/5088751004942336/