Opened 4 years ago

Closed 2 years ago

Last modified 6 months ago

#3702 closed defect (rejected)

Adblock Plus sometimes tries to access undefined properties after shutdown

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)

Environment

Mozilla Firefox 44.0.2
Adblock Plus 2.7.2

How to reproduce

  1. Install Adblock Plus
  2. Disable it via Add-ons Manager.

Observed behaviour

Error messages in Browser Console:

Full message: TypeError: require is not a function
Full stack: exports.Utils.yield@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/utils.js:354:19
INIParser.prototype.process@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:798:7
exports.IO.readFromFile/onProgress@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:97:15
exports.IO.readFromFile/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:182:11
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:1

Full message: TypeError: Cu is null
Full stack: exports.FilterStorage.loadFromDisk/readFile</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:380:11
exports.IO.readFromFile/onError@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:149:9
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:21
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:1

Expected behaviour

It should gracefully shutdown.

Additional notes

The io module is still triggering callbacks after the extension is shut down. It should check onShutdown.done for any async processing.

Change History (7)

comment:1 Changed 4 years ago by trev

  • Cc trev added
  • Description modified (diff)
  • Keywords crawler removed
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from ABP for firefox tries to access undefined properties on shutdown in crawler to Adblock Plus sometimes tries to access undefined properties after shutdown

This is a cosmetic problem, not only affecting crawler however. I've adjusted the description accordingly.

comment:2 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

comment:3 Changed 13 months ago by takken3

spam

Last edited 6 months ago by kzar (previous) (diff)

comment:4 Changed 11 months ago by SharrySteve1

spam

Last edited 6 months ago by kzar (previous) (diff)

comment:5 Changed 9 months ago by SharrySteve1

spam

Last edited 6 months ago by kzar (previous) (diff)

comment:6 Changed 8 months ago by Munna123

spam

Last edited 6 months ago by kzar (previous) (diff)

comment:7 Changed 6 months ago by Mary31

I am getting a build error (below) it seems you need to add ruby-rdoc as a dependency. It was split from ruby earlier this year.
https://www.icrwatch.com/

Version 0, edited 6 months ago by Mary31 (next)
Note: See TracTickets for help on using tickets.