Opened 3 years ago

Closed 3 years ago

#3709 closed defect (fixed)

[abp2blocklist] Filters aren't normalized before parsing

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29337800/

Description (last modified by sebastian)

Background

The abp2blocklist command line script doesn't normalize the filters to be converted before parsing them. This is causing an inconsistency with Adblock Plus which normalizes all filters when the subscription got downloaded. So trailing spaces for example are ignored in Adblock Plus, but considered part of the filter here.

What to change

Take care to call Filter.normalize on the filter text before passing it to Filter.fromText in the abp2blocklist.js script.

Change History (2)

comment:1 Changed 3 years ago by sebastian

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from [abp2blocklist] abp2blocklist script is not normalising filters to [abp2blocklist] Filters aren't normalized before parsing

comment:2 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.