#3710 closed change (fixed)

[abp2blocklist] Unify hostname logic

Reported by: sebastian Assignee: kzar
Priority: P3 Milestone:
Module: Platform Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29337803/

Description (last modified by kzar)

Background

Since #3670, the state machine converting filter patterns to regular expressions, also detects hostnames in order to make filters case sensitive when possible.

However, in order to convert IDN hostnames to punycode we still rely on following regexp:

/^(\|\||\|?https?:\/\/)([\w\-.*\u0080-\uFFFF]+)/i

Besides that regular expression not being completely accurrate, we shouldn't have redundant logic to identify hostnames.

What to change

Move the logic to encode domains as punycode to the state machine converting filters to regular expressions.

Change History (4)

comment:1 Changed 22 months ago by kzar

  • Description modified (diff)
  • Owner set to kzar
  • Review URL(s) modified (diff)

comment:2 Changed 22 months ago by kzar

  • Status changed from new to reviewing

comment:3 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/abp2blocklist/rev/349d23311c0c

comment:4 Changed 22 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.