Opened 4 years ago

Closed 4 years ago

#3724 closed change (fixed)

Add JsValue::Call(const JsValue&)

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29337850/

Description

Background

Currently there is a method JsValuePtr Call(const JsValueList& params = JsValueList(), JsValuePtr thisPtr = JsValuePtr()) const; which accepts JsValueList which is essentially std::vector<std::shared_ptr<JsValue>>.
However we are not always able to construct it

  • e.g. #1863
  • when we need to pass this object as an argument from a constant method of this object (we do it in Notification::GetTexts() const).

Additional argument is that we often need to pass merely one parameter and it's inconvenient for the caller to construct JsValueList each time.

What to change

Add JsValue::Call(const JsValue&) method.

Change History (2)

comment:1 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/libadblockplus/rev/0f110844b4bc

comment:2 Changed 4 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.