Opened 3 years ago

Last modified 7 weeks ago

#3725 new change

Implement Notifications

Reported by: rjeschke Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: mario, fhd, tpregueiro Blocked By: #6238
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

As the title says. Notifications weren't part of the first draft.

Change History (6)

comment:1 Changed 13 months ago by jwangenheim

  • Cc mario fhd added

@mario
I talked about this issue with @fhd a while ago and he said that we will use notifications only for cross product promotion with ABB and ABP for desktop. I think this ticket can be closed because it's only a draft anyway.

comment:2 Changed 13 months ago by fhd

There are multiple types of notifications. Ideally we support all types on all platforms. But we need to support at the very least emergency notifications on all platforms. See https://bitbucket.org/adblockplus/spec/src/7a0f1650ecd7e92067e4114a787b51dd45a9e012/spec/abp/notifications.md?at=master&fileviewer=file-view-default#markdown-header-notification-types

comment:3 follow-up: Changed 13 months ago by jwangenheim

Then I probably misunderstood you and we should keep the ticket and extend it a little more. By emergency you mean the type which is referred to as "Critical" or "Relentless"?
As far as I can see, we don't have any designs for notifications for mobile yet, right? It would be good if we had at least a wireframe prototype to start working on that issue.
Maybe we can discuss this later in the Android Developer meeting.

comment:4 in reply to: ↑ 3 Changed 13 months ago by fhd

  • Cc tpregueiro added

Replying to jwangenheim:

Then I probably misunderstood you and we should keep the ticket and extend it a little more. By emergency you mean the type which is referred to as "Critical" or "Relentless"?

Just "Critical" is sufficient for starters. All the others are nice to have.

As far as I can see, we don't have any designs for notifications for mobile yet, right? It would be good if we had at least a wireframe prototype to start working on that issue.
Maybe we can discuss this later in the Android Developer meeting.

Yeah, we have no real idea of how to show notifications yet. I've looped in Tiago so he can think about it.

comment:5 Changed 10 months ago by mario

  • Blocked By 6238 added

comment:6 Changed 3 months ago by johnson83

removed

Last edited 7 weeks ago by nelkington (previous) (diff)
Note: See TracTickets for help on using tickets.