Opened 4 years ago

Closed 4 years ago

#3731 closed change (fixed)

Updated bundled easylist and exceptionrules

Reported by: mario Assignee: rjeschke
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.1
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by rjeschke)

Background

Adblock Plus for Samsung Browser comes with bundled easylist and exceptionsrules. Those are used as initial filter lists until an update is performed. As the update only happens on WiFi (default setting), we need to update those bundled lists to ensure that we don't loose users because of outdated initial filter lists.

What to change

Update the bundled easylist.txt and exceptionsrules.txt for Adblock Plus for Samsung Browser

Change History (7)

comment:1 Changed 4 years ago by rjeschke

  • Description modified (diff)
  • Owner set to rjeschke
  • Platform changed from Android to Samsung Browser

comment:3 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:4 Changed 4 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Summary changed from Update filter list to Updated bundled easylist and exceptionrules

comment:5 Changed 4 years ago by mario

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Currently, if the user has Wifi enabled, they can update their filter lists with the newly added exception and the page appears to function as normal on m.naver.com, which was the main reason for this update.

However, if the user already has the app installed and has the update option set to 'Only update via wifi' then once they have updated the app the issue will still occur. From my understanding, this is because 1. The filter list is not updated automatically due to the update process only occurring over Wifi and 2. because the update of the app to the fixed list does not overwrite the already installed list from the old version. From talking to Rene, getting the app to overwrite the old filter list is no easy feat.

So, the long and short of it is - users who do not, will not and have not updated their filter list via Wifi and have their update setting set to 'Update via Wifi only' will not have the issue resolved.

comment:7 Changed 4 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set

The release will go ahead with this fix implemented. The issue I had previously stated above still stands, but turns out to be an issue that was present even before this fix was applied. Because of this, I will now close this issue, as it has already been resolved, if only for WiFi users.

The new issue where the users old filter list does not get replaced upon updating can be found here: https://issues.adblockplus.org/ticket/3762#no4

Note: See TracTickets for help on using tickets.