Opened 5 years ago

Last modified 13 months ago

#3732 new change

Always update repositories to the master bookmark

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: jsonesen, kvas, matze Blocked By:
Blocking: #3663 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


See #3663.

What to change

Specifically update to the master bookmark after cloning or pulling in the following modules:

  • sitescripts.extensions.bin.updateRecommendations
  • sitescripts.extensions.utils
  • sitescripts.content_blocker_lists.bin.generate_lists
  • sitescripts.notifications.parser
  • sitescripts.subscriptions.knownIssuesParser
  • sitescripts.subscriptions.subscriptionParser

Change History (8)

comment:1 Changed 5 years ago by trev

  • Cc trev added
  • Description modified (diff)

I added the missing modules to the list. Some are marked with a question mark - these relate to subscriptions, not sure whether we want to enforce the same logic there. At least for the subscriptionlist repository we probably do.

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Ready set

comment:3 Changed 4 years ago by fhd

  • Cc jsonesen added
  • Description modified (diff)

sitescripts.extensions.bin.createNightlies was covered by #4540.

Jon, also fancy covering the remaining modules here? :) Then we can use feature bookmarks in pretty much all repos without side effects.

comment:4 Changed 4 years ago by jsonesen

Yeah, I can definitely do this. I am looking into #4653 right now as well which seems related. Thanks for cc'ing me!

comment:5 Changed 4 years ago by jsonesen

  • Cc kvas added

comment:6 Changed 4 years ago by kvas

  • Priority changed from Unknown to P3

Thanks for adding me, Jon. The issue is a bit brief, but seems clear enough after reading #3663. I guess it's becoming more urgent now since we're starting to rely on bookmarks more.

comment:7 Changed 3 years ago by fhd

  • Cc trev removed

comment:8 Changed 13 months ago by kvas

  • Cc matze added

Hey, I'm trying to close the old sitescripts tickets in Trac.

Questions (probably @matze could answer them easiest).

  • Is this ticket still relevant?
  • If yes, should it go to infrastructure somehow or the new home of sitescripts in GitLab?


Note: See TracTickets for help on using tickets.