Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3737 closed change (fixed)

[logprocessor] Parse user agent strings from MS Edge

Reported by: sebastian Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: trev Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340823/

Description

Background

The logprocessor currently doesn't handle Edge, when identifying the browser, presumably recognizing it as Chrome since Edge uses a similar user agent string.

What to change

Make the logprocessor identify requests from MS Edge. For reference, the user agent strings of Edge is based on one from Chrome, but add and Edge/ token to the end.

Change History (5)

comment:1 Changed 4 years ago by kvas

  • Owner set to kvas

comment:2 Changed 4 years ago by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/sitescripts/rev/1d748c6ebc9e

comment:4 Changed 4 years ago by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by sebastian

  • Keywords edge removed
  • Platform changed from Unknown / Cross platform to Edge
Note: See TracTickets for help on using tickets.