Opened 2 years ago

Closed 2 years ago

#3741 closed change (fixed)

Add "remove" option to list items in new options page

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: athornburgh, saroyanm, sebastian Blocked By:
Blocking: #2355 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29338983/

Description (last modified by greiner)

Background

It is non-obvious what effects checking or unchecking a checkbox has on the item. Therefore we should add a "remove" option to removable list items.

Furthermore, the "popular" label is misleading and should be removed since it doesn't add any value anymore.

See also the design mockup.

What to change

  • Remove "popular" label from "Further blocking lists" section
  • Add "x" button to the right of each removable list item on General tab (see default state, hover state)
  • Whitelisted websites section
    • Remove "x" button on the left
    • Align domains in Whitelisted websites section to the left

Attachments (3)

gray_x.png (738 bytes) - added by greiner 2 years ago.
red_x.png (846 bytes) - added by greiner 2 years ago.
Options_Page_CHANGES.png (197.5 KB) - added by greiner 2 years ago.

Download all attachments as: .zip

Change History (12)

Changed 2 years ago by greiner

Changed 2 years ago by greiner

Changed 2 years ago by greiner

comment:1 Changed 2 years ago by greiner

  • Description modified (diff)

comment:2 Changed 2 years ago by greiner

  • Blocking 2355 added
  • Cc athornburgh saroyanm sebastian added
  • Priority changed from Unknown to P2
  • Ready set

comment:3 follow-up: Changed 2 years ago by sebastian

We are about to add pre-configurable subscriptions which are supposed to be not removable (#3801). In the old options page you cannot remove subscriptions that are given in Prefs.additional_subscriptions. So we have to account for that here as well.

Last edited 2 years ago by sebastian (previous) (diff)

comment:4 in reply to: ↑ 3 Changed 2 years ago by greiner

Replying to sebastian:

We are about to add pre-configurable subscriptions which are supposed to be not removable (#3801). In the old options page you cannot remove subscriptions that are given in Prefs.additional_subscriptions. So we have to account for that here as well.

In that case it might make sense to reintroduce the labelling of filter lists (formerly known as "popular" label) so that we're transparent about that some of those are recommended by us while others are recommended by the organization.

comment:5 Changed 2 years ago by sebastian

Well, if there is no label at all, we won't indicate anything wrong, I guess. Also keep in mind that this is quite an edge case; users, whose organization has rolled out Adblock Plus with additional filter subscriptions, coming to the options page. So FWIW, I think treating these subscriptions the same as our suggested subscriptions would be good enough, in particular for the initial release of the new options page.

comment:6 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:7 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
issue 3741 - Add 'remove' option to list items in new options page

comment:9 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.