Opened 13 months ago

Last modified 10 months ago

#3742 new change

Make behavior of checkboxes on options page consistent

Reported by: greiner Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: athornburgh, saroyanm, sebastian Blocked By:
Blocking: #2355 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

It is non-obvious what effects checking or unchecking a checkbox has on the item. Therefore we should simplify the logic and make it more consistent.

Checkbox behavior (current/expected)

Language filter lists

  • current: adds/removes list item
  • expected: adds/removes filter list

Recommended filter lists

  • current: enables/disables list item
  • expected: adds/removes filter list

Custom filter lists

  • current: adds/removes list item
  • expected: adds/removes filter list

Acceptable Ads

  • current: enables/disables list item
  • expected: adds/removes filter list

Filter lists in Advanced tab

  • current: enables/disables list item
  • expected: enables/disables filter list

Preferences in Tweaks section

  • current: enables/disables list item
  • expected: enables/disables preference

What to change

  • Checkboxes for removable list items (language filter lists, custom filter lists) should enable or disable the item
  • Checkboxes for non-removable list items (recommended filter lists, Acceptable Ads, filter lists in Advanced tab) should add or remove the item

Change History (3)

comment:1 Changed 12 months ago by greiner

  • Description modified (diff)

comment:2 Changed 10 months ago by saroyanm

Should this be covered in #3741 ?

comment:3 Changed 10 months ago by sebastian

Seem like separate issues to me.

Note: See TracTickets for help on using tickets.