Opened 19 months ago

Closed 5 months ago

#3742 closed change (invalid)

Make behavior of checkboxes on options page consistent

Reported by: greiner Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: athornburgh, saroyanm, sebastian, wspee Blocked By:
Blocking: #2355 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

It is non-obvious what effects checking or unchecking a checkbox has on the item. Therefore we should simplify the logic and make it more consistent.

Checkbox behavior (current/expected)

Language filter lists

  • current: adds/removes list item
  • expected: adds/removes filter list

Recommended filter lists

  • current: enables/disables list item
  • expected: adds/removes filter list

Custom filter lists

  • current: adds/removes list item
  • expected: adds/removes filter list

Acceptable Ads

  • current: enables/disables list item
  • expected: adds/removes filter list

Filter lists in Advanced tab

  • current: enables/disables list item
  • expected: enables/disables filter list

Preferences in Tweaks section

  • current: enables/disables list item
  • expected: enables/disables preference

What to change

  • Checkboxes for removable list items (language filter lists, custom filter lists) should enable or disable the item
  • Checkboxes for non-removable list items (recommended filter lists, Acceptable Ads, filter lists in Advanced tab) should add or remove the item

Change History (5)

comment:1 Changed 18 months ago by greiner

  • Description modified (diff)

comment:2 Changed 16 months ago by saroyanm

Should this be covered in #3741 ?

comment:3 Changed 16 months ago by sebastian

Seem like separate issues to me.

comment:4 Changed 5 months ago by saroyanm

  • Cc wspee added

@Winsley before closing this ticket make sense to be sure that this request is being reflected in the specifications.

comment:5 Changed 5 months ago by wspee

  • Resolution set to invalid
  • Status changed from new to closed

This doesn't apply to the new new options page (see #5158) and since it won't be implemented (see #2706) I'm closing this as invalid.

Note: See TracTickets for help on using tickets.