Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3747 closed change (fixed)

Update Element Hiding Helper dependency on buildtools to revision c92cc4e4a338

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.3.8
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)

Background

We fixed #2850 which affects Element Hiding Helper extension as well. This dependency update will import additional changes however:

What to change

After updating dependency prefs.json has to be moved from default/ to lib/. Also, we will have to add needMultiprocessShims=true to the manifest (EHH isn't E10S-compatible).

Change History (4)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/elemhidehelper/rev/164aadf1a493

comment:3 Changed 3 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working in both E10S and non-E10S Firefox with no obvious regressions.

Firefox 38 / 44 / 45 / Nightly 49.0a1 / Windows 7
Firefox 38 / 44 / 45 / OS X 10.11
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Ubuntu 14.04

Version 0, edited 3 years ago by Ross (next)
Note: See TracTickets for help on using tickets.