Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3748 closed change (fixed)

Update URL Fixer dependency on buildtools to revision c92cc4e4a338

Reported by: trev Assignee: trev
Priority: P2 Milestone: URL-Fixer-4.1.2
Module: URL-Fixer Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29337915/

Description

Background

We fixed #2850 which affects URL Fixer extension as well. This dependency update will import additional changes however:

What to change

After updating dependency prefs.json has to be moved from default/ to lib/, typoRules.json has to be moved from default/ to chrome/content. Also, we will need to check whether the extension works correctly in E10S mode.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/urlfixer/rev/85dfdb402703

comment:3 Changed 4 years ago by trev

  • Milestone set to URL-Fixer-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working in both E10S and non-E10S Firefox with no obvious regressions.

ABP 2.7.3 / URLFixer 4.1.1.317
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Windows 7
Firefox 38 / 44 / 45 / OS X 10.11
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.