Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#375 closed defect (fixed)

toggling "Enabled/Disabled on this site" function sometimes leads to two "Block element" context menu entries

Reported by: philll Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5095280043098112/

Description

Environment

Chrome 34
ABP 1.7.4.1161 with no filters active

How to reproduce

  1. Go to https://in.yahoo.com/
  2. Click the ABP icon
  3. Toggle "Enabled/Disabled on this site"
  4. Right click at some image
  5. Repeat 2-4 several times, switch to another tab and back in between

Observed behaviour

Sometimes, the context menu contains an "Adblock Plus" entry, showing two "Block image" entries if hovered. Apparently, this reproduction approach is not 100% reliable. I often needed to sort-of-randomly switch between tabs and keep toggling ABP on and off in between, while retrying the context menu.

Expected behaviour

There should always be only one "Block image" entry in the context menu.

Change History (4)

comment:1 Changed 6 years ago by sebastian

  • Owner set to sebastian
  • Status changed from new to assigned

comment:2 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

This also fixes a related issue, where the context menu entry were shown when switching from a tab with ABP enabled to a tab with ABP disabled, and vice versa.

https://hg.adblockplus.org/adblockpluschrome/rev/b24488858c2f

comment:4 Changed 6 years ago by trev

  • Component changed from Unknown to Platform
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.