Opened 6 years ago

Closed 6 years ago

#376 closed defect (fixed)

trac's nginx blocks large file uploads

Reported by: philll Assignee: trev
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5650091033493504

Description

Environment

http://issues.adblockplus.org

How to reproduce

  1. At an existing issue, try to upload a file with 4.7 MB

Observed behaviour

Nginx returns the following: 413 Request Entity Too Large

Expected behaviour

The file should upload. Trac's limit via settings currently is 10Mb, which seems reasonable for issue file uploads.

Change History (4)

comment:1 Changed 6 years ago by philll

  • Ready set

comment:2 Changed 6 years ago by trev

  • Owner set to trev
  • Status changed from new to assigned

Currently we don't set the client_max_body_size setting meaning that it defaults to 1 MB. We can set it to 15 MB for this host, then it will be well beyond Trac's limit.

comment:3 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:4 Changed 6 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.