Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3760 closed change (fixed)

Remove the "opera" build target

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29337971
https://codereview.adblockplus.org/29337967

Description

Background

Historically, we have seperate builds for Chrome and Opera. That was because early Chromuim-based versions of Opera still had quite some differences requiring changes to the build. However, meanwhile our Chrome and Opera builds are identical, except for the browser name mentioned in the short description which can just be changed. So we don't need to support a separate build target for Opera anymore, but can simply provide the same builds as for Chrome.

What to change

  • Merge the short description of Adblock Plus for Chrome, Opera and Safari
  • Remove support for ./build.py -t opera

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/dbc98c6fc5bc

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/dd7d4352824f

comment:4 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Works as expected. The Opera specific target has been removed and building/installing Chrome/Opera builds as described in the README.

adblockpluschrome / 37693c923e69

Last edited 4 years ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.