Opened 4 years ago

Last modified 3 years ago

#3765 new defect

After clicking the 'enable' button, the ABP icon is not displayed in the status bar.

Reported by: passbrains Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #3394
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by scheer)

The issue here is that if the user selects to 'Enable' the extension, then the icon should already be displayed in the status bar, even if the extension is enabled in the background.

The user should be receiving some form of proof that the extension is running already, even without a restart.

Adapted from https://platform.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-128

Environment

Windows 7 64 Bit
ABP version 1.4.798

How to reproduce

  1. Start installation of the latest version of ABP for IE with IE open
  2. The user gets a message that IE should be closed so that he doesn't need to restart the browser
  3. Click Yes and wait for the installation to complete
  4. When opening IE the user receives a message from the browser asking if they wish to enable the New add-on installed
  5. Click on the Enable button and wait
  6. The ABP icon id not shown to user
  7. Now close IE and then re-open

Observed behaviour

ABP icon doesn't get shown when the user clicks on the 'Enable' button first time.
Closing the IE 11 and opening again shows up the icon.

Expected behaviour

The ABP icon should be shown to users in the status bar when the user clicks on the enable button in the notification fist time.

Attachments (1)

13317_1457434319_Untitled.jpg (149.7 KB) - added by passbrains 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by passbrains

comment:1 Changed 4 years ago by passbrains

1 - 09 Mar 2016 12:31:09 posted by Scott Cheer
I was able to reproduce this on Windows 7 64 Bit - IE 9 ABP 1.4.798.

I am not quite sure if this is an IE issue, which requires a restart to be able to show the icon in the status bar after it being enabled, or if it is truly something we are able to force, once the user has selected the 'Enable' button?

comment:2 Changed 4 years ago by scheer

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Description modified (diff)
  • Summary changed from Even after clicking enable button , the ABP icon doesn't get enabled first time to After clicking the 'enable' button, the ABP icon is not displayed in the status bar.

comment:3 Changed 4 years ago by scheer

  • Description modified (diff)

comment:4 Changed 4 years ago by scheer

  • Description modified (diff)

comment:5 Changed 3 years ago by eric@…

  • Blocked By 3394 added

This has the same underlying cause as #712, which is that updating the status bar is haphazard and inconsistent. In #712, it's redrawn when it doesn't need to be, leading to flicker, and in the present issue, it's not redrawn when it ought to be.

There's no single place in the code that has responsibility for maintaining status bar state consistently, which is the approach in #3394, now marked as blocking this issue.

Note: See TracTickets for help on using tickets.