Restore default ABP bookmarks

[rjeschke]

Mozilla changed the way mobile bookmarks work, i.e. removed those and is now using the desktop ones. This change currently breaks the tests for building Fennec. A temporary solution to get the build working again is to disable the tests by adding ac_add_options --disable-tests to your mozconfig.

Previously bookmarks were defined via a locale specific bookmarks.inc file in the mobile folder. See ​here. The corresponding string definitions were to be found ​here (Those strings are currently commented out in branch abb_fennec_44_0_2_merge).

With the latest merge, Mozilla has removed the mobile specific bookmarks.inc file.

We need a way to get the bookmarks and their strings working again.

Furthermore we need to remove the predefined Mozilla bookmarks.

Hints for Testers

The project should build without the need of adding ac_add_options --disable-tests to the mozconfig file

After installing the app, check if these bookmarks are added by default:
About your browser (about:)
Acceptable Ads (​https://acceptableads.org)
Adblock Plus (​https://adblockplus.org)
Beta community (​https://adblockplus.org/redirect?link=adblock_browser_android_beta_community)

After installing the app, check if these bookmarks are not added:
Firefox: About your browser (about:firefox)
Firefox: Customize with add-ons (​https://addons.mozilla.org/android/)
Firefox: Support (​https://support.mozilla.org/products/mobile)
Learn the Web: Mozilla Webmaker (​https://webmaker.org/)
Firefox Help and Support for restricted profiles on Android tablets (​https://support.mozilla.org/kb/controlledaccess)

[abpbot]

A commit referencing this issue has landed:
​Issue 3766 - Restore default ABP bookmarks

[scheer]

Is there any more updates on the change here. Did we use this method in the end, to get the build to function or did we revert since then? could we have some more information to the issue and maybe add some hints for testers?

Thanks

[scheer]

• After installing the app, the following bookmarks are added by default:
  • About your browser (about:)
  • Acceptable Ads (​​https://acceptableads.org)
  • Adblock Plus (​​https://adblockplus.org)
  • Beta community (​​https://adblockplus.org/redirect?link=adblock_browser_android_beta_community)

• After installing the app, the following bookmarks are not added:
  • Firefox: About your browser (about:firefox)
  • Firefox: Customize with add-ons (​​https://addons.mozilla.org/android/)
  • Firefox: Support (​​https://support.mozilla.org/products/mobile)
  • Learn the Web: Mozilla Webmaker (​​https://webmaker.org/)
  • Firefox Help and Support for restricted profiles on Android tablets (​​https://support.mozilla.org/kb/controlledaccess)