Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#3766 closed defect (fixed)

Restore default ABP bookmarks

Reported by: rjeschke Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29346676/

Description (last modified by diegocarloslima)

Mozilla changed the way mobile bookmarks work, i.e. removed those and is now using the desktop ones. This change currently breaks the tests for building Fennec. A temporary solution to get the build working again is to disable the tests by adding ac_add_options --disable-tests to your mozconfig.

Previously bookmarks were defined via a locale specific bookmarks.inc file in the mobile folder. See here. The corresponding string definitions were to be found here (Those strings are currently commented out in branch abb_fennec_44_0_2_merge).

With the latest merge, Mozilla has removed the mobile specific bookmarks.inc file.

We need a way to get the bookmarks and their strings working again.

Furthermore we need to remove the predefined Mozilla bookmarks.

Hints for Testers

The project should build without the need of adding ac_add_options --disable-tests to the mozconfig file

After installing the app, check if these bookmarks are added by default:
About your browser (about:)
Acceptable Ads (https://acceptableads.org)
Adblock Plus (https://adblockplus.org)
Beta community (https://adblockplus.org/redirect?link=adblock_browser_android_beta_community)

After installing the app, check if these bookmarks are not added:
Firefox: About your browser (about:firefox)
Firefox: Customize with add-ons (https://addons.mozilla.org/android/)
Firefox: Support (https://support.mozilla.org/products/mobile)
Learn the Web: Mozilla Webmaker (https://webmaker.org/)
Firefox Help and Support for restricted profiles on Android tablets (https://support.mozilla.org/kb/controlledaccess)

Change History (10)

comment:1 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:2 Changed 4 years ago by diegocarloslima

  • Owner set to diegocarloslima

comment:3 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:4 Changed 4 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 3766 - Restore default ABP bookmarks

comment:7 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 2 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Is there any more updates on the change here. Did we use this method in the end, to get the build to function or did we revert since then? could we have some more information to the issue and maybe add some hints for testers?

Thanks

comment:9 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:10 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
Version 0, edited 2 years ago by scheer (next)
Note: See TracTickets for help on using tickets.