Opened 4 years ago

Last modified 3 years ago

#3766 closed defect

Restore default ABP bookmarks — at Version 5

Reported by: rjeschke Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29346676/

Description (last modified by rjeschke)

Mozilla changed the way mobile bookmarks work, i.e. removed those and is now using the desktop ones. This change currently breaks the tests for building Fennec. A temporary solution to get the build working again is to disable the tests by adding ac_add_options --disable-tests to your mozconfig.

Previously bookmarks were defined via a locale specific bookmarks.inc file in the mobile folder. See here. The corresponding string definitions were to be found here (Those strings are currently commented out in branch abb_fennec_44_0_2_merge).

With the latest merge, Mozilla has removed the mobile specific bookmarks.inc file.

We need a way to get the bookmarks and their strings working again.

Furthermore we need to remove the predefined Mozilla bookmarks.

Change History (5)

comment:1 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:2 Changed 4 years ago by diegocarloslima

  • Owner set to diegocarloslima

comment:3 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:4 Changed 4 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by diegocarloslima

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.