Changes between Version 2 and Version 3 of Ticket #3771


Ignore:
Timestamp:
03/11/2016 03:35:45 PM (4 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3771 – Description

    v2 v3  
    11=== Background === 
    2 With #3659 `InvalidFilter.reason` is no longer a translated string but a message id. The calling code needs to be adapted accordingly. 
     2With #3659 `InvalidFilter.reason` is no longer a translated string but a string ID. The calling code needs to be adapted accordingly. Also we need to update the `adblockplus` dependency at the same time to import the [https://hg.adblockplus.org/adblockplus/rev/1e8c64115e5b related strings]. 
    33 
    44Also with #3660 support for some legacy filter lists have been removed. This however doesn't require any changes to the code here. 
     
    77 
    88=== What to change === 
    9 Update the `adblockpluscore` dependency to `3b518ca1bfcc` and adapt the code in the `filterValidation` module in order to pass `InvalidFilter.reason` to `Utils.getString()`. 
     9* Update the `adblockpluscore` dependency to `3b518ca1bfcc`. 
     10* Update the `adblockplus` dependency to `1e8c64115e5b` and import related strings. 
     11* Adapt existing code for `InvalidFilter.reason` being a string ID. 
    1012 
    1113=== Hints for testers ===