Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3772 closed defect (fixed)

Anti-adblock warning removal list isn't subscribed by default anymore

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338118

Description (last modified by sebastian)

How to reproduce

(Re-)Install Adblock Plus on Chrome or Safari and go to the options.

Observed behaviour

With the previous release version Adblock Plus 1.10.2 the Anti-Adblock warning removal list was subscribed by default though disabled. And when you visited particular websites you would get a notification to enable that list. But that doesn't happen anymore.

This regression was introduced by #3685 as not all of the migration code removed was actually outdated.

Expected behaviour

New users hsould be subscribed to the anti-adblock warning removal list. The list should be disabled.

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/37693c923e69

comment:4 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

ABP 1.11.0.1597
Chrome 32 / 44 / 48 / Windows 8
Opera 24 / 28 / Windows 8
Chrome 44 / Ubuntu 14.04
Safari 6 / 8 / 9 / OS X 10.8 / 10.10 / 10.11

Note: See TracTickets for help on using tickets.