Opened on 03/11/2016 at 09:30:49 AM

Closed on 03/15/2016 at 07:26:57 PM

#3775 closed defect (fixed)

abpcrawler does not log requests anymore

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: abpcrawler
Cc: trev Blocked By:
Blocking: #3780 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)


ABP 2.7.2
Firefox 44.0.2

How to reproduce

  • run it

Observed behaviour

In a json file in the output directory there is no property requests.

Expected behaviour

In in json file corresponding to each URL there should be an array property request where each entry contains location, request type and filters applied for the request.

Additional note

It seems filters are broken already quite a long and since abpcrawler has stopped to save even request locations because abpcrawler used Policy.processNode from lib/contentPolicy.js.

To get similar behavior we can use RequestNotifier in the chrome (parent process) script.

Attachments (0)

Change History (7)

comment:1 Changed on 03/11/2016 at 10:00:14 AM by sergz

  • Description modified (diff)

comment:2 Changed on 03/11/2016 at 10:35:48 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/11/2016 at 10:48:33 AM by sergz

  • Blocking 3780 added

comment:4 Changed on 03/15/2016 at 09:30:38 AM by trev

  • Component changed from Unknown to Extensions-for-Adblock-Plus
  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed on 03/15/2016 at 09:38:36 AM by trev

  • Cc trev added

comment:6 Changed on 03/15/2016 at 07:22:14 PM by abpbot

A commit referencing this issue has landed:

comment:7 Changed on 03/15/2016 at 07:26:57 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.