Opened 4 years ago

Closed 4 years ago

#3799 closed change (fixed)

Add malware domains list mirrors to sitescripts configuration

Reported by: kvas Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: sebastian Blocked By:
Blocking: #3810 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29338260

Description

In order for the malware domains lists conversion script to use the mirrors (see #3774) the list of the mirrors should be added to sitescripts configuration file (see review for an example).

Without the configuration changes the script can still work in its currently proposed form with the hardcoded default list of mirrors. If the configuration changes are deployed to the servers before the changes are applied to the script the hardcoding doesn't need to be introduced, which would be preferable.

Thank you

Change History (7)

comment:1 Changed 4 years ago by kvas

The list of mirrors to add is the same as in the example in the review:

malwaredomains_mirrors=
	http://mirror3.malwaredomains.com
	http://mirror1.malwaredomains.com
	http://mirror2.malwaredomains.com

comment:2 Changed 4 years ago by matze

  • Cc sebastian added; matze snoack removed
  • Owner set to matze
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 4 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by kvas

  • Blocking 3810 added

comment:5 Changed 4 years ago by kvas

  • Blocking 3774 removed

comment:6 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/6eadff29bb96

comment:7 Changed 4 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.