Opened 4 years ago

Closed 4 years ago

Last modified 2 months ago

#3801 closed change (fixed)

Add pre-configurable/hidden preference to add additional subscriptions

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29338315

Description (last modified by sebastian)

Background

Some organizations that deploy Adblock Plus for Chrome using group policies need a way to add additional filter subscriptions.

We already support a preference that can be pre-configured by group policies in order to suppress the first run page. The same mechanism can be used to allow central configuration of additional filter subscriptions.

What to change

  • Support another pre-configurable preference with the name additional_subscriptions and the type array of string. That preference will contain a list of URLs of filter subscriptions, which can be configured by group policy.
  • When Adblock Plus is loaded, subscriptions given by that preference should be automatically added.
  • It should not be possible to remove those subscriptions on the options page, since they would be automatically added again.
  • However, the user should still be able to disable them. When disabled those subscriptions should NOT be automatically enabled again.

Change History (19)

comment:1 Changed 4 years ago by sebastian

  • Component changed from Unknown to Platform
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/a5c02038c610

comment:3 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by sebastian

On Linux, for example, adding a file with following contents under /etc/opt/chrome/policies/managed/adblockplus.json will cause EasyPrivacy to be added as additional subscription:

{
  "3rdparty": {
    "extensions": {
      "ldcecbkkoecffmfljeihcmifjjdoepkn": {
        "additional_subscriptions": [
          "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
        ]
      }
    }
  }
}

On Windows, according to my understanding of Chromium's incomplete documentation, you would have to set following group policy to achieve the same:

[HKLM\Software\Policies\Google\Chrome\3rdparty\extensions\ldcecbkkoecffmfljeihcmifjjdoepkn\policy\additional_subscriptions]
"1" = "https://easylist-downloads.adblockplus.org/easyprivacy.txt"

Also note that the extension IDs in the snippets above refer to the Adblock Plus development build.

comment:5 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:6 Changed 4 years ago by Ross

The Linux version works but I have not got the Windows version to work yet in a VM. Have tried various root keys (HKLM, HKLU) and methods. Will try an actual Windows machine.

ABP 1.11.1606
Chrome 31, 45 / Windows 7
Chrome 49 / Ubuntu 14.04

comment:7 Changed 4 years ago by sebastian

For Windows this needs to be configured via Active Directory. For more details please refer to the documentation linked above. Frankly, I never tried it out myself on Windows, since it's not trivial to set it up.

comment:8 Changed 11 months ago by DavidPeacock

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:9 Changed 9 months ago by zindara

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:10 Changed 8 months ago by tomberrot

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:11 Changed 8 months ago by jessicabelorr

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:12 Changed 8 months ago by tonnyken

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:13 Changed 7 months ago by MollyB

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:14 Changed 7 months ago by amdin

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:15 Changed 7 months ago by AlexGambler

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:16 Changed 6 months ago by mage17

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:17 Changed 4 months ago by zerathomaz

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:18 Changed 4 months ago by jessicabelorr

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:19 Changed 3 months ago by vinabiz

spam

Last edited 2 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.