Opened 5 years ago

Closed 5 years ago

#381 closed change (fixed)

Update to nginx 1.6

Reported by: trev Assignee: christian
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: fhd Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5716525453410304/

Description

Background

Our servers currently use nginx 1.4 which is the legacy branch now - current stable and supported release is nginx 1.6. The only change that seems relevant for us is the support for SPDY 3.1. Also, sub_filter_last_modified directive should be relevant for the main server.

What to change

Update to nginx 1.6, verify that it doesn't create any issues in the test environments (nginx 1.2 to 1.4 update actually produced issues with the way we listened to IPv6 addresses).

Change History (8)

comment:1 Changed 5 years ago by fhd

I'm pretty sure 1.4 is going to get security updates, from Ubuntu if not from upstream. I agree that we shouldn't wait too long, but this doesn't seem like a P2 change.

comment:2 Changed 5 years ago by trev

We don't install nginx from Ubuntu.

comment:3 Changed 5 years ago by trev

  • Priority changed from P2 to P3

comment:4 Changed 5 years ago by christian

  • Owner set to christian
  • Status changed from new to assigned

I make the change and put it up to review

http://codereview.adblockplus.org/5716525453410304/

comment:5 Changed 5 years ago by christian

  • Review URL(s) modified (diff)

comment:6 Changed 5 years ago by trev

  • Status changed from assigned to reviewing

comment:7 Changed 5 years ago by trev

I've updated to nginx 1.6 on the unmanaged servers, no issues it seems.

comment:8 Changed 5 years ago by christian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.