Opened on 03/15/2016 at 11:25:14 PM

Closed on 03/17/2016 at 09:17:13 AM

#3810 closed change (fixed)

Remove hardcoded default mirror list from Malware Domains List conversion script

Reported by: kvas Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian Blocked By: #3799
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29338412/

Description

Support for multiple mirrors of the Malware Domains List was implemented in the ​conversion script (see #3774). At the moment the configuration changes (#3799) have not hit the servers yet, so the defaults are hardcoded in the script.

This ticket covers the removal of the hardcoded defaults from the script once the updated configuration makes it to the servers.

Attachments (0)

Change History (4)

comment:1 Changed on 03/16/2016 at 10:37:01 AM by sebastian

  • Ready set

comment:2 Changed on 03/16/2016 at 11:28:32 AM by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/16/2016 at 07:00:44 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/sitescripts/rev/0adee5c816e1

comment:4 Changed on 03/17/2016 at 09:17:13 AM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.