Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3813 closed change (fixed)

Update dependency on adblockplusui to revision eaf7a04285fa

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2401 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)

Background

This will import changes relevant for CSS property filters, via #2396. The other changes are:

What to change

Locale strings from common.json have to be imported.

What to test

Functionality of the first-run page has to be retested.

Change History (5)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)
  • Summary changed from Update dependency on adblockplusui to revision 0e4b41190cf5 to Update dependency on adblockplusui to revision eaf7a04285fa

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/55d607fb8b35

comment:3 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by trev

  • Blocking 2401 added

comment:5 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Strings are displayed on first-run page. First-run page functionality (subscription toggles, social media buttons) still work as expected. The linked tickets should probably be verified in conjunction with the new UI when it's in the build (have made a note).

ABP 2.7.2.4166
Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Note: See TracTickets for help on using tickets.