Opened on 03/16/2016 at 01:35:51 PM

Closed on 03/16/2016 at 03:01:38 PM

Last modified on 04/25/2016 at 02:32:27 AM

#3813 closed change (fixed)

Update dependency on adblockplusui to revision eaf7a04285fa

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2401 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)


This will import changes relevant for CSS property filters, via #2396. The other changes are:

What to change

Locale strings from common.json have to be imported.

What to test

Functionality of the first-run page has to be retested.

Attachments (0)

Change History (5)

comment:1 Changed on 03/16/2016 at 02:56:09 PM by trev

  • Description modified (diff)
  • Summary changed from Update dependency on adblockplusui to revision 0e4b41190cf5 to Update dependency on adblockplusui to revision eaf7a04285fa

comment:2 Changed on 03/16/2016 at 03:00:53 PM by abpbot

A commit referencing this issue has landed:

comment:3 Changed on 03/16/2016 at 03:01:38 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed on 03/16/2016 at 03:17:16 PM by trev

  • Blocking 2401 added

comment:5 Changed on 04/25/2016 at 02:32:27 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Strings are displayed on first-run page. First-run page functionality (subscription toggles, social media buttons) still work as expected. The linked tickets should probably be verified in conjunction with the new UI when it's in the build (have made a note).

Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.