Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3823 closed change (fixed)

Split up message responder code

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338503
https://codereview.adblockplus.org/29338491

Description

Background

In background.js we currently have one huge ext.onMessage listener that handles messages for each part of the extension. However, some of that code would rather belong into their respective modules.

Moreover, ext.onMessage is just a thin wrapper mimicking chrome.runtime.onMessage which has some issues that got addressed with the new messaging API we going to use on Firefox, see #3499.

What to change

  • Implement the subset of #3499 supporting Port.on and Port.off.
  • Migrate the messaging code in background.js to the new API.
  • Move message responders out to their respective module where applicable.

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed 3 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Change doesn't look to have caused any obvious regressions. Context menu, subscriptions, state changes, icon, devtools panel are working as expected still.

ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.