Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3828 closed change (fixed)

Ignore simulated clicks on abp:subscribe links

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338592

Description

Background

Websites can simulate a click on abp:subscribe links. While the user still needs to confirm the subscription to be added, this can be irritating in particular if websites repeatedly do that.

What to change

Ignore simulated clicks on abp:subscribe links based on Event.isTrusted (where supported).

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/4d845c1d2115

comment:3 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Tested via attempting to click it via the console and via a script added to a locally served copy of the testpages (and its subscribe link).

ABP 1.11.0.1606
Chrome 45, 50 / Windows 7
Chrome 45, 50 / OS X 10.11
Chrome 49 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.