Opened on 03/17/2016 at 09:50:16 PM

Closed on 03/18/2016 at 01:37:10 PM

Last modified on 05/09/2016 at 07:11:28 AM

#3830 closed defect (fixed)

Filters saved through "Block element" override existing filters

Reported by: mapx Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: User-Interface Keywords:
Cc: sebastian, kzar, greiner Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mapx)


windows 10
chrome 50

How to reproduce

  • add a custom filter (manually or using "block element")
  • go to whatever page, click ABP icon, use "block element" ==> create a new filter.
  • see the custom filters ==> the first filter(s) was removed

the stable 1.11 is working fine.

Attachments (0)

Change History (12)

comment:1 Changed on 03/17/2016 at 09:51:48 PM by mapx

  • Description modified (diff)

comment:2 Changed on 03/18/2016 at 07:55:49 AM by mapx

  • Cc greiner added

comment:3 Changed on 03/18/2016 at 10:58:28 AM by greiner

I assume this is a regression from #3761 because it turns out that the filters.importRaw message not only adds new filters but also removes other filters because it was initially only meant for being used for the custom filters textbox in the options page.

Therefore we could either extend the filters.importRaw message or even merge it with filters.add to achieve the expected behavior.

comment:4 Changed on 03/18/2016 at 12:53:19 PM by sebastian

  • Component changed from Platform to User-Interface

I confirm, greiner's conclusion. To fix that, I suggest to add an option to filter.importRaw indicating whether to remove existing filters. I'm not sure about merging filters.importRaw and filters.add though since the code diverge seems to be quite large.

comment:5 Changed on 03/18/2016 at 01:09:21 PM by sebastian

  • Owner set to sebastian

comment:6 Changed on 03/18/2016 at 01:10:05 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from dev build breaks the custom filters feature to Filters saved through "Block element" override existing filters

comment:7 Changed on 03/18/2016 at 01:23:39 PM by greiner

  • Ready set

comment:8 Changed on 03/18/2016 at 01:23:53 PM by greiner

  • Priority changed from Unknown to P1

comment:9 Changed on 03/18/2016 at 01:31:54 PM by abpbot

A commit referencing this issue has landed:

comment:10 Changed on 03/18/2016 at 01:36:39 PM by abpbot

A commit referencing this issue has landed:

comment:11 Changed on 03/18/2016 at 01:37:10 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed on 05/09/2016 at 06:52:30 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Chrome 32 / 50 / Windows 10
Opera 23 / 36 / Windows 10
Chrome 32 / 50 / OS X 10.11
Opera 23 / 36 / OS X 10.11
Safari 6 / 7 / 9.1 / OS X 10.8/10.9/10.11
Chrome 50 / Ubuntu 14.04

Last edited on 05/09/2016 at 07:11:28 AM by Ross

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.