Opened on 03/18/2016 at 12:28:42 PM

Closed on 03/18/2016 at 02:17:22 PM

Last modified on 04/22/2016 at 02:46:29 PM

#3836 closed change (fixed)

Don't set DownloadableSubscription.upgradeRequired in Synchronizer

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #3835 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



#3660 removed DownloadableSubscription.upgradeRequired property yet Synchronizer is still setting it.

What to change

Don't set this property, code using it should calculate it itself.

Attachments (0)

Change History (5)

comment:1 Changed on 03/18/2016 at 12:29:02 PM by trev

  • Blocking 3835 added; 2401 removed

comment:2 Changed on 03/18/2016 at 12:31:31 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/18/2016 at 02:16:41 PM by abpbot

A commit referencing this issue has landed:

comment:4 Changed on 03/18/2016 at 02:17:22 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 04/22/2016 at 02:46:29 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This change looks to be working as expected.

Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.