Opened 4 years ago

Last modified 4 years ago

#3836 closed change

Don't set DownloadableSubscription.upgradeRequired in Synchronizer — at Version 2

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #3835 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338611/

Description

Background

#3660 removed DownloadableSubscription.upgradeRequired property yet Synchronizer is still setting it.

What to change

Don't set this property, code using it should calculate it itself.

Change History (2)

comment:1 Changed 4 years ago by trev

  • Blocking 3835 added; 2401 removed

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.