Opened 4 years ago

Last modified 4 years ago

#3841 closed change

Remove workaround stripping [style] selectors on certain websites. — at Initial Version

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29338761

Description

Background

In 2011, a bug in Chrome was found that broke some functionality in Google Mail (apparently Yahoo Mail was effected as well), when an extension injects any CSS rules using selectors that target the style attribute.

As a workaround Adblock Plus stripped all element hiding filters using such selectors on mail.google.com, www.google.com and mail.yahoo.com.

However, I cannot reproduce that issue anymore. And given that the bug is 5 years old chances that the same code in Chrome and/or Google Mail that caused the issue back then still exists is rather low anyway. If a similar bug still exists, it most likely effects a different set of websites anyway.

What to change

Remove the workaround stripping selectors that target the style attribute on some websites.

Change History (0)

Note: See TracTickets for help on using tickets.