Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3842 closed change (fixed)

Split up the logic updating the icon and context menu

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338764

Description

Background

There is code in background.js to update the icon and context menu. This code however rather belongs into the icon and filterComposer modules.

What to change

  • Move the logic detecting whether a page's whitelisting status changed into the whitelisting module.
  • Split up the logic updating the icon and context menu, and move it into the icon and filterComposer modules.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/f9af47ee1d80

comment:3 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Change does not look to have caused any regressions with icon and context menu. Whitelisting works as expected and the icon/context menu pick up on the change.

ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.