Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3846 closed change (fixed)

Add notification for users using an old SBrowser version

Reported by: mario Assignee: rjeschke
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29339199/

Description (last modified by vickyyu)

Background

Samsung released Samsung Internet (aka SBrowser) 4.0 for Android Lollipop which enables Lollipop users to use content blockers. (So far this has only been possible for Marshmallow users.)

Thus we're aiming for updating ABP for Samsung Browser in the Google Play Store to remove the restriction for Lollipop which enables Lollipop users to download and use ABP for Samsung Browser as well.
However if users using Lollipop haven't updated SBrowser to version 4.0 already and go ahead and download ABP for Samsung Browser, ABP won't work. Thus we need to detect the SBrowser version on ABP start-up and notify the user to update SBrowser if needed.

What to change

Implement a standard Android notification as shown in this workflow under Step 3 and reduce the minimum Android API version to 21 (Android 5).

The notification is shown on every ABP startup if all of the following requirements are met:

  • The user runs any Android version above Android 5 (Lollipop)
  • The user runs any SBrowser version older than 4.0

The notification is not closable.

Ressources

Notification Text
Notification headline:
Update your browser

Notification body:
Before you can use Adblock Plus, you must update to Samsung Internet Browser 4.0.

After installing the update for Samsung Internet Browser, relaunch Adblock Plus to finish.

Notification button:
Get update

Attachments (2)

ABP_for_iOS_ALERT_v2.0.pdf (147.4 KB) - added by mario 3 years ago.
ABP_for_SamsungBrowser_First-run_V3.pdf (348.9 KB) - added by vickyyu 3 years ago.

Download all attachments as: .zip

Change History (17)

Changed 3 years ago by mario

comment:1 Changed 3 years ago by mario

  • Description modified (diff)

comment:2 Changed 3 years ago by rjeschke

  • Component changed from Adblock-Browser-for-Android to Adblock-Plus-for-Samsung-Browser
  • Owner set to rjeschke
  • Platform changed from Adblock Browser for Android to Samsung Browser
  • Priority changed from Unknown to P2

comment:3 Changed 3 years ago by vickyyu

The Samsung Browser 4.0 is only going to be available for Android 5.0 and above, so the notification requirement "The user runs any Android version older than Marshmallow" should be revised to "The users runs any Android 5.0 and above" to exclude users with Android versions older than 5.0.

comment:4 Changed 3 years ago by vickyyu

  • Cc vickyyu added

comment:5 follow-up: Changed 3 years ago by scheer

Additionally the image shown for 'in this workflow under Step 3' is an iOS pop-up style guide (ABP_for_iOS_ALERT_v2.0.pdf). Was the wrong screenshot uploaded?

Changed 3 years ago by vickyyu

comment:6 Changed 3 years ago by vickyyu

  • Description modified (diff)

comment:7 in reply to: ↑ 5 Changed 3 years ago by vickyyu

Replying to scheer:

Additionally the image shown for 'in this workflow under Step 3' is an iOS pop-up style guide (ABP_for_iOS_ALERT_v2.0.pdf). Was the wrong screenshot uploaded?

Thanks! I've added the right screenshot (ABP_for_SamsungBrowser_First-run_V3.pdf) and updated the link in the description. I hope @rene has got the right one.

comment:8 Changed 3 years ago by rjeschke

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 3 years ago by rjeschke

  • Description modified (diff)

comment:10 Changed 3 years ago by vickyyu

  • Description modified (diff)

comment:11 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer

The notification flow runs as described in ABP_for_SamsungBrowser_First-run_V3.pdf, however, after step 8, Samsung Browser does not open and the user is not able to enable the content blocking options.

However, if the user manually enters into Samsung Browser and unlocks the content blocker by entering 'about:contentblock' in the address bar, then selecting Settings > advanced > blocking, they are then able to enable the content blocker.

Galaxy S5 - Android 5.0
Galaxy S4 - Android 5.0.1
Galaxy S6 - Android 6.0.1

comment:12 Changed 3 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.2

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussbrowser/rev/0235d72d590a

comment:14 Changed 3 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 3 years ago by scheer

  • Verified working set

ABP Sbrowser adblockplussbrowser-1.0.2-20160426113120-release
Sbrowser 4.0
Samsung Galaxy S5
Android 5.0

  • The user is now able to update to the latest version of Sbrowser (4.0) after launching ABP for the first time and selecting the option 'Get Update' on Android 5.0.
  • The first time message of the required browser update links the user correctly to the Sbrowser version within the Google Play Store.
  • Once the user has upgraded and launched the updated Sbrowser at least once, then the user is able to launch ABP again and proceed with the normal setup of ABP in Sbrowser.

I must note here, that in ABP_for_SamsungBrowser_First-run_V3.pdf, steps 4 and 5 are wrong. When the user is taken to the store page, the options that are displayed are 'Upgrade' in white on the left and 'Open' in Green on the right. Normally this is not an issue, but this could lead to confusion for the user as, where in the screenshots the user is automatically loaded into the updated Sbrowser after install, the actual behaviour is that that once the Sbrowser is upgraded, they are not loaded immediately into the Sbrowser at all. If the user then opens ABP without opening Sbrowser, then ABP will not initialise correctly and when ABP attempts to launch Sbrowser to enable ABP, nothing happens.

So, assuming that the user opens Sbrowser at least once after the upgrade before trying to launch ABP and enable it, then this is fine. But, if they don't launch Sbrowser at all after upgrading, then they will hit the issue mentioned above.

Note: See TracTickets for help on using tickets.